Fix bug where start/end values are not updated correctly after initialization#27
Merged
SBlokhuizen merged 2 commits intodevelopfrom Mar 4, 2025
Merged
Conversation
maarten-ic
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a recently introduced bug, where the
start_valueandend_valuewould not get updated.self.values_changed = Trueis now called at the end of initialization of the tendency to ensure the
start_valueandend_valueare updated accordingly. This fixes an issue where the end_value would not get updated, and the next tendency would take the wrong start value. For example:Would before give:

And now:

Also, this fixes the issue where a warning would be given because the end of previous tendency would not exactly equal the start of the current tendency, due to floating point precision.